Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: support creating recovery systems with components from the store #14883

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

andrewphelpsj
Copy link
Member

@andrewphelpsj andrewphelpsj commented Dec 18, 2024

Based on #14882 for now. feaf8f9 is the first commit relevant to this PR.

This PR allows us to create recovery systems using the /v2/systems API that contain components.

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Dec 18, 2024
@andrewphelpsj andrewphelpsj force-pushed the create-rec-system-components-from-store branch 3 times, most recently from 97dcdbc to f5b4456 Compare December 19, 2024 21:38
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 54.77273% with 199 lines in your changes missing coverage. Please review.

Project coverage is 78.27%. Comparing base (24a0034) to head (f5b4456).
Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
tests/lib/fakestore/refresh/snap_asserts.go 0.00% 79 Missing ⚠️
tests/lib/fakestore/store/store.go 67.94% 35 Missing and 15 partials ⚠️
overlord/devicestate/devicestate.go 81.66% 15 Missing and 7 partials ⚠️
...estore/cmd/fakestore/cmd_new_snap_resource_pair.go 0.00% 18 Missing ⚠️
...re/cmd/fakestore/cmd_new_snap_resource_revision.go 0.00% 18 Missing ⚠️
overlord/devicestate/systems.go 77.08% 8 Missing and 3 partials ⚠️
snap/snaptest/snaptest.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14883      +/-   ##
==========================================
+ Coverage   78.20%   78.27%   +0.07%     
==========================================
  Files        1151     1148       -3     
  Lines      151396   152936    +1540     
==========================================
+ Hits       118402   119714    +1312     
- Misses      25662    25842     +180     
- Partials     7332     7380      +48     
Flag Coverage Δ
unittests 78.27% <54.77%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewphelpsj andrewphelpsj force-pushed the create-rec-system-components-from-store branch from f5b4456 to ff1739f Compare December 20, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant