-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many: support creating recovery systems with components from the store #14883
Open
andrewphelpsj
wants to merge
8
commits into
canonical:master
Choose a base branch
from
andrewphelpsj:create-rec-system-components-from-store
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
many: support creating recovery systems with components from the store #14883
andrewphelpsj
wants to merge
8
commits into
canonical:master
from
andrewphelpsj:create-rec-system-components-from-store
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
Label automatically added which indicates the change needs documentation
label
Dec 18, 2024
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
3 times, most recently
from
December 19, 2024 21:38
97dcdbc
to
f5b4456
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14883 +/- ##
==========================================
+ Coverage 78.20% 78.27% +0.07%
==========================================
Files 1151 1148 -3
Lines 151396 152936 +1540
==========================================
+ Hits 118402 119714 +1312
- Misses 25662 25842 +180
- Partials 7332 7380 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…files being named <name>.comp.comp
… creating recovery systems with components from the store
…equire snaps that are at least in the model
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
from
December 20, 2024 14:09
f5b4456
to
ff1739f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Documentation -auto-
Label automatically added which indicates the change needs documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14882 for now. feaf8f9 is the first commit relevant to this PR.
This PR allows us to create recovery systems using the /v2/systems API that contain components.